Add 'reload' service subcommand to ectl

This commit is contained in:
2025-11-06 18:48:26 +02:00
parent 87412f20f8
commit 5ed1128e43
4 changed files with 216 additions and 29 deletions
+53 -1
View File
@@ -57,7 +57,59 @@ func main() {
return return
} else if flag.Args()[0] == "service" || flag.Args()[0] == "sv" { } else if flag.Args()[0] == "service" || flag.Args()[0] == "sv" {
if len(flag.Args()) <= 1 { if len(flag.Args()) <= 1 {
fmt.Println("Usage: ectl service <start/stop/enable/disable/status/list> [service]") fmt.Println("Usage: ectl service <reload/start/stop/enable/disable/status/list> [service]")
return
}
if flag.Arg(1) == "reload" {
type ServiceCommandJsonStruct struct {
Command string `json:"command"`
Service string `json:"service"`
}
serviceCommandJson := ServiceCommandJsonStruct{
Command: flag.Arg(1),
}
// Encode struct to json string
jsonData, err := json.Marshal(serviceCommandJson)
if err != nil {
log.Fatalf("Could not encode JSON data! Error: %s\n", err)
}
_, err = conn.Write(jsonData)
if err != nil {
log.Fatalf("Could not write JSON data to socket! Error: %s\n", err)
}
// Create a buffer for incoming data.
buf := make([]byte, 4096)
// Read data from the connection.
n, err := conn.Read(buf)
if err != nil {
return
}
// Print json data if flag is set
if *printJson {
fmt.Println(string(buf[:n]))
return
}
// Decoode JSON data
var returnedJsonData map[string]any
err = json.Unmarshal(buf[:n], &returnedJsonData)
if err != nil {
log.Fatalf("Could not decode JSON data from connection!")
}
if err, ok := returnedJsonData["error"]; ok {
log.Fatal(err)
} else if msg, ok := returnedJsonData["success"]; ok {
fmt.Println(msg)
} else {
log.Fatal("Connection returned empty string!")
}
return return
} else if flag.Arg(1) == "start" || flag.Arg(1) == "stop" || flag.Arg(1) == "restart" { } else if flag.Arg(1) == "start" || flag.Arg(1) == "stop" || flag.Arg(1) == "restart" {
// Ensure service name argument has been set // Ensure service name argument has been set
+26 -13
View File
@@ -1,6 +1,7 @@
package main package main
import ( import (
"crypto/sha256"
"flag" "flag"
"fmt" "fmt"
"io" "io"
@@ -143,19 +144,21 @@ func Init() {
} }
service := EnitService{ service := EnitService{
Name: "", Name: "",
Description: "", Description: "",
Dependencies: make([]string, 0), Dependencies: make([]string, 0),
Type: "", Type: "",
StartCmd: "", StartCmd: "",
ExitMethod: "", ExitMethod: "",
StopCmd: "", StopCmd: "",
Restart: "", Restart: "",
CrashOnSafeExit: true, CrashOnSafeExit: true,
restartCount: 0, LogOutput: true,
stopChannel: make(chan bool), Filepath: path.Join(serviceConfigDir, "services", entry.Name()),
LogOutput: true, filepathChecksum: sha256.Sum256(bytes),
state: EnitServiceUnloaded, restartCount: 0,
stopChannel: make(chan bool),
state: EnitServiceUnloaded,
} }
if err := yaml.Unmarshal(bytes, &service); err != nil { if err := yaml.Unmarshal(bytes, &service); err != nil {
logger.Printf("Error: could not read service file %s", path.Join(serviceConfigDir, "services", entry.Name())) logger.Printf("Error: could not read service file %s", path.Join(serviceConfigDir, "services", entry.Name()))
@@ -227,6 +230,16 @@ func Init() {
logger.Println("ESVM initialized successfully!") logger.Println("ESVM initialized successfully!")
} }
func Reload() {
logger.Println("Reloading all ESVM services...")
for _, service := range Services {
service.ReloadService()
}
logger.Println("All ESVM services have been reloaded!")
}
func Destroy() { func Destroy() {
logger.Println("Stopping all ESVM services...") logger.Println("Stopping all ESVM services...")
+129 -15
View File
@@ -1,6 +1,7 @@
package main package main
import ( import (
"crypto/sha256"
"fmt" "fmt"
"io" "io"
"os" "os"
@@ -37,21 +38,24 @@ var EnitServiceStateNames map[EnitServiceState]string = map[EnitServiceState]str
} }
type EnitService struct { type EnitService struct {
Name string `yaml:"name"` Name string `yaml:"name"`
Description string `yaml:"description,omitempty"` Description string `yaml:"description,omitempty"`
Dependencies []string `yaml:"dependencies,omitempty"` Dependencies []string `yaml:"dependencies,omitempty"`
Type string `yaml:"type"` Type string `yaml:"type"`
StartCmd string `yaml:"start_cmd"` StartCmd string `yaml:"start_cmd"`
ExitMethod string `yaml:"exit_method"` ExitMethod string `yaml:"exit_method"`
CrashOnSafeExit bool `yaml:"crash_on_safe_exit"` CrashOnSafeExit bool `yaml:"crash_on_safe_exit"`
StopCmd string `yaml:"stop_cmd,omitempty"` StopCmd string `yaml:"stop_cmd,omitempty"`
Restart string `yaml:"restart,omitempty"` Restart string `yaml:"restart,omitempty"`
ReadyFd int `yaml:"ready_fd"` ReadyFd int `yaml:"ready_fd"`
LogOutput bool `yaml:"log_output,omitempty"` LogOutput bool `yaml:"log_output,omitempty"`
state EnitServiceState Filepath string
processID int filepathChecksum [32]byte
restartCount int state EnitServiceState
stopChannel chan bool processID int
restartCount int
stopChannel chan bool
shouldReload bool
} }
var Services = make([]*EnitService, 0) var Services = make([]*EnitService, 0)
@@ -117,6 +121,90 @@ func (service *EnitService) GetLogFile() (file *os.File, err error) {
return file, nil return file, nil
} }
func (service *EnitService) ReloadService() {
bytes, err := os.ReadFile(service.Filepath)
checksum := sha256.Sum256(bytes)
if slices.Equal(checksum[:], service.filepathChecksum[:]) {
return
}
if service.state == EnitServiceStarting || service.state == EnitServiceRunning {
service.shouldReload = true
logger.Printf("Warning: Service (%s) is currently running and will be reloaded when stopped\n", service.Name)
return
}
service.shouldReload = false
logger.Printf("Reloading service (%s)...\n", service.Filepath)
if os.IsNotExist(err) {
Services = slices.DeleteFunc(Services, func(sv *EnitService) bool {
return sv == service
})
logger.Printf("Service (%s) has been removed\n", service.Name)
return
} else if err != nil {
logger.Printf("Error: Could not read service file (%s)", service.Filepath)
return
}
newService := EnitService{
Name: "",
Description: "",
Dependencies: make([]string, 0),
Type: "",
StartCmd: "",
ExitMethod: "",
StopCmd: "",
Restart: "",
CrashOnSafeExit: true,
LogOutput: true,
Filepath: service.Filepath,
filepathChecksum: checksum,
restartCount: service.restartCount,
stopChannel: service.stopChannel,
state: service.state,
}
if err := yaml.Unmarshal(bytes, &newService); err != nil {
logger.Printf("Error: could not read service file %s", service.Filepath)
return
}
for _, sv := range Services {
if sv.Name == newService.Name && sv != service {
logger.Printf("Error: service with name (%s) has already been initialized", service.Name)
}
}
switch newService.Type {
case "simple", "background":
default:
logger.Printf("Error: unknown service type (%s)", newService.Type)
return
}
switch newService.ExitMethod {
case "stop_command", "kill":
default:
logger.Printf("Error: unknown exit method (%s)\n", newService.ExitMethod)
return
}
switch newService.Restart {
case "true", "always":
default:
newService.Restart = "false"
}
for i, sv := range Services {
if sv == service {
Services[i] = &newService
}
}
logger.Printf("Service (%s) has been reloaded!\n", newService.Name)
}
func (service *EnitService) StartService() (err error) { func (service *EnitService) StartService() (err error) {
if service == nil { if service == nil {
return nil return nil
@@ -218,6 +306,14 @@ func (service *EnitService) StartService() (err error) {
service.restartCount = 0 service.restartCount = 0
if service.ExitMethod != "stop_command" { if service.ExitMethod != "stop_command" {
service.state = EnitServiceCompleted service.state = EnitServiceCompleted
// Reload service if needed
if service.shouldReload {
service.ReloadService()
if GetServiceByName(service.Name) == nil {
return
}
}
} else { } else {
service.state = EnitServiceRunning service.state = EnitServiceRunning
} }
@@ -231,6 +327,15 @@ func (service *EnitService) StartService() (err error) {
service.state = EnitServiceCrashed service.state = EnitServiceCrashed
} }
// Reload service if needed
if service.shouldReload {
service.ReloadService()
if GetServiceByName(service.Name) == nil {
return
}
service = GetServiceByName(service.Name)
}
if service.Restart == "always" { if service.Restart == "always" {
_ = service.StartService() _ = service.StartService()
} else if service.Restart == "true" && service.restartCount < 5 { } else if service.Restart == "true" && service.restartCount < 5 {
@@ -263,6 +368,15 @@ func (service *EnitService) StopService() error {
defer func() { defer func() {
service.state = newServiceStatus service.state = newServiceStatus
service.processID = 0 service.processID = 0
// Reload service if needed
if service.shouldReload {
service.ReloadService()
if GetServiceByName(service.Name) == nil {
return
}
service = GetServiceByName(service.Name)
}
}() }()
if service.ExitMethod == "kill" { if service.ExitMethod == "kill" {
+8
View File
@@ -17,6 +17,7 @@ func initSocket() (socket net.Listener, err error) {
} }
// Register command handlers // Register command handlers
commandHandlers["reload"] = handleReloadServicesCommand
commandHandlers["start"] = handleStartServiceCommand commandHandlers["start"] = handleStartServiceCommand
commandHandlers["stop"] = handleStopServiceCommand commandHandlers["stop"] = handleStopServiceCommand
commandHandlers["restart"] = handleRestartServiceCommand commandHandlers["restart"] = handleRestartServiceCommand
@@ -74,6 +75,13 @@ func listenToSocket() {
}(conn) }(conn)
} }
func handleReloadServicesCommand(conn net.Conn, jsonData map[string]any) {
// Reload services
Reload()
conn.Write(wrapSuccessMsgInJson("Services reloaded successfully"))
}
func handleStartServiceCommand(conn net.Conn, jsonData map[string]any) { func handleStartServiceCommand(conn net.Conn, jsonData map[string]any) {
// Get service name from json data // Get service name from json data
serviceName, ok := jsonData["service"] serviceName, ok := jsonData["service"]