38 lines
1.4 KiB
Diff
38 lines
1.4 KiB
Diff
From 27f8690db999f6e56f0af7a9ea3d28a019ed72ca Mon Sep 17 00:00:00 2001
|
|
From: Fumitoshi Ukai <[email protected]>
|
|
Date: Tue, 30 Jun 2026 18:32:03 -0700
|
|
Subject: [PATCH] don't depends on histograms.xml if it is not git checkout
|
|
|
|
histograms.xml is only generated on git checkout.
|
|
|
|
Bug: 329080012
|
|
Change-Id: Iea4484f8af4cf9ef25e25ea1df2c616fbe46ed5c
|
|
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8019063
|
|
Reviewed-by: Jesse McKenna <[email protected]>
|
|
Commit-Queue: Fumitoshi Ukai <[email protected]>
|
|
Auto-Submit: Fumitoshi Ukai <[email protected]>
|
|
Cr-Commit-Position: refs/heads/main@{#1655184}
|
|
---
|
|
|
|
diff --git a/tools/metrics/BUILD.gn b/tools/metrics/BUILD.gn
|
|
index c826e97..23799c7 100644
|
|
--- a/tools/metrics/BUILD.gn
|
|
+++ b/tools/metrics/BUILD.gn
|
|
@@ -41,11 +41,11 @@
|
|
]
|
|
|
|
# Only include histograms_xml if we have access to dirmd data, which
|
|
- # is used to populate ownership information. This is only set to false
|
|
- # for non-git checkouts.
|
|
- # TODO(crbug.com/329080012): Remove this once dirmd works in non-git
|
|
- # checkouts.
|
|
- if (generate_location_tags) {
|
|
+ # is used to populate ownership information. This is disabled
|
|
+ # for non-git checkouts, as dirmd doesn't work on non-git checkout.
|
|
+ # TODO(crbug.com/329080012): Remove this condition once dirmd works
|
|
+ # in non-git checkouts.
|
|
+ if (path_exists("//.git")) {
|
|
deps += [ ":histograms_xml" ]
|
|
}
|
|
}
|